truncate prefixes above the selected level to make the download layout flat #2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsvmx
requested review from
bexsoft,
cesnietor,
dvaldivia,
jinapurapu,
kaankabalak and
reivaj05
Collaborator
|
Tested LGTM, objects are now being downloaded in their corresponding path as expected. |
cesnietor
approved these changes
Aug 9, 2023
pjuarezd
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
truncate prefixes above the selected level to make the download layout flat
Since objects are selected at nested level, we could ignore the top level prefixes when zip is created to make the layout flat.