Connected delete & download buttons for object details #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
force-pushed
the
connect-buttons
branch
from
1d37edd to
7287ccd
Compare
dvaldivia
approved these changes
Nov 18, 2020
kaankabalak
approved these changes
Nov 18, 2020
Contributor
kaankabalak
left a comment
kaankabalak
left a comment
There was a problem hiding this comment.
Looking good to me, maybe in the future we might want to add a Snackbar to notify the user that the object has been deleted similar to what we do when we upload an object.
Collaborator
Author
Will create a ticket for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Connects download & delete buttons from object details view