Skip to content

Conversation

@Alevsk
Copy link
Contributor

@Alevsk Alevsk commented Nov 18, 2020

Previously cookie path was set to Path="/api", this was a performance
improvement to tell the browser to send the cookie only to request with
that prefix, however also consume endpoints on Path="/ws", since rfc6265
doesnt support multiple paths or regular expressions in the path field
of a cookie we are back to use Path="/" which means send the cookie to
all request under the current domain.

Screen Shot 2020-11-18 at 11 42 55 AM

Previously cookie path was set to Path="/api", this was a performance
improvement to tell the browser to send the cookie only to request with
that prefix, however also consume endpoints on Path="/ws", since rfc6265
doesnt support multiple paths or regular expressions in the path field
of a cookie we are back to use Path="/" which means send the cookie to
all request under the current domain.
@Alevsk Alevsk self-assigned this Nov 18, 2020
@Alevsk Alevsk linked an issue Nov 18, 2020 that may be closed by this pull request
@cesnietor
Copy link
Collaborator

I'm not able to login in operator-ui:

│ 2020/11/18 20:05:02 session token internal data is malformed                        │
│ 2020/11/18 20:05:04 cipher: message authentication failed                           │
│ 2020/11/18 20:05:04 encrypted session token claims not in the right format          │
│ 2020/11/18 20:05:04 session token internal data is malformed 

@cesnietor
Copy link
Collaborator

I'm not able to login in operator-ui:

│ 2020/11/18 20:05:02 session token internal data is malformed                        │
│ 2020/11/18 20:05:04 cipher: message authentication failed                           │
│ 2020/11/18 20:05:04 encrypted session token claims not in the right format          │
│ 2020/11/18 20:05:04 session token internal data is malformed 

nvm, I was able to login

Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested lgtm

@dvaldivia dvaldivia merged commit f1db949 into minio:master Nov 18, 2020
@Alevsk Alevsk deleted the cookie-path-fix branch November 19, 2020 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logs + Trace websockets are not connecting

3 participants