Skip to content

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Nov 21, 2020

What does this do?

Implements Legal Hold modal

How does it look?

Screen Shot 2020-11-23 at 13 29 24

Screen Shot 2020-11-23 at 13 29 19

@bexsoft bexsoft added WIP This PR is WIP and cannot be merged yet UI User Interface labels Nov 21, 2020
@bexsoft bexsoft added this to the V1 Drop milestone Nov 21, 2020
@bexsoft bexsoft self-assigned this Nov 21, 2020
@bexsoft bexsoft force-pushed the legal-hold branch 2 times, most recently from 8c373f7 to 9bae220 Compare November 23, 2020 19:21
@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label Nov 23, 2020
@bexsoft bexsoft changed the title [WIP] Legal hold modal implementation Legal hold modal implementation Nov 23, 2020
Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2020-11-23 at 6 54 54 PM

if an error occurs the button save doesn't reset.

@bexsoft
Copy link
Collaborator Author

bexsoft commented Nov 24, 2020

Screen Shot 2020-11-23 at 6 54 54 PM

if an error occurs the button save doesn't reset.

Should be fixed now

@bexsoft bexsoft requested a review from cesnietor November 24, 2020 03:39
cesnietor
cesnietor previously approved these changes Nov 24, 2020
@kaankabalak
Copy link
Contributor

Would it be possible to format the error message such that it is consistent with the rest of the error messages in the app?

Screen Shot 2020-11-24 at 11 08 28 AM

@bexsoft
Copy link
Collaborator Author

bexsoft commented Nov 24, 2020

Would it be possible to format the error message such that it is consistent with the rest of the error messages in the app?

Screen Shot 2020-11-24 at 11 08 28 AM

Added styles:

Screen Shot 2020-11-24 at 15 03 13

We will change all the error messages as mentioned in #99

@bexsoft bexsoft requested a review from cesnietor November 24, 2020 21:08
@cesnietor cesnietor merged commit 2caad99 into minio:master Nov 25, 2020
@bexsoft bexsoft deleted the legal-hold branch November 25, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants