Connected Share object modal #440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Regardless of link length, should we make the field for the URL a single line as in the mockups given here? We might want to consult @belvid or @Jayshreemagdum if we would like to make the field scrollable |
cesnietor
requested changes
Nov 24, 2020
Collaborator
cesnietor
left a comment
cesnietor
left a comment
There was a problem hiding this comment.
Creating an optimized production build...
Failed to compile.
./src/screens/Console/Common/FormComponents/DateSelector/DateSelector.tsx
Line 209:34: Unexpected use of 'name' no-restricted-globals
Line 232:60: Unexpected use of 'name' no-restricted-globals
Line 254:55: Unexpected use of 'name' no-restricted-globals
Search for the keywords to learn more about each error.
bexsoft
force-pushed
the
share-connect
branch
from
cb0215f to
d1ccc91
Compare
Collaborator
Author
Fixed, it was an issue with lint rules that was not detected during development. |
Collaborator
Author
Will make it horizontal, in this case I will fill a new ticket to make this class a new component as there may be some issues with paddings:
|
kaankabalak
approved these changes
Nov 24, 2020
cesnietor
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Connects Share object modal with API
How does it look?