Move heal and watch to tenant details view on operator-ui #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
force-pushed
the
move-watch-heal-operator
branch
from
794f8ef to
07703ea
Compare
Alevsk
suggested changes
Nov 25, 2020
Contributor
Alevsk
left a comment
Alevsk
left a comment
There was a problem hiding this comment.
Will test and make sure there's no TLS issues with websockets
Contributor
|
On the watch screen when I select a bucket and then click start im seeing the TLS verification Error (MinIO is running with TLS enabled), ill quickly debug this and send a pr to your branch @cesnietor |
Alevsk
added a commit
to Alevsk/console
that referenced
this pull request
Nov 28, 2020
…TP clients - We preserve the insecure parameter in the `newS3Config` and `NewAdminClientWithInsecure` functions for debugging and testing purposes. - By default InsecureSkipVerify is false, therefore in order for Operator-Console to verify the TLS connections to MinIO tenants with self-signed certificates it requires the `ca.crt` or the `public.crt` of the tenant to exists under `~/.console/certs/CAs` which is the right way to do it. This PR depends on: - minio#449 - https://github.com/cesnietor/console/pull/3/files
Alevsk
added a commit
to Alevsk/console
that referenced
this pull request
Nov 28, 2020
Use insecure: true in the meantime so the wss/watch endpoint works while we add support for custotm TLS transport in the S3 client library. Removed "InsecureSkipVerify: true" from s3AdminClient and s3Client HTTP clients - We preserve the insecure parameter in the `newS3Config` and `NewAdminClientWithInsecure` functions for debugging and testing purposes. - By default InsecureSkipVerify is false, therefore in order for Operator-Console to verify the TLS connections to MinIO tenants with self-signed certificates it requires the `ca.crt` or the `public.crt` of the tenant to exists under `~/.console/certs/CAs` which is the right way to do it. This PR depends on: - minio#449
Contributor
I sent a PR to fix the above issue @cesnietor cesnietor#3, then I have a second PR cesnietor#4 but this one requires a release on mc. |
Use insecure: true in the meantime so the wss/watch endpoint works while we add support for custotm TLS transport in the S3 client library. Removed "InsecureSkipVerify: true" from s3AdminClient and s3Client HTTP clients
cesnietor
force-pushed
the
move-watch-heal-operator
branch
from
3ed5eac to
4629b6f
Compare
bexsoft
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/minio/console/issues/418
Changes were done on websocket implementations and on UI.
Should be testing deploying console as console operator on a kubernetes environment.