Skip to content

Add retention option on bucket creation api #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2020
Merged

Add retention option on bucket creation api #504

merged 3 commits into from
Dec 11, 2020

Conversation

@cesnietor
Copy link
Collaborator

@cesnietor cesnietor commented Dec 11, 2020 •
edited
Loading

This also deletes a bucket if it was created and an error occurred.
POST on api/v1/buckets:

{
  "name": "bucket1", 
  "versioning" : true,
  "retention" : {
    "mode": "governance",
    "unit": "days",
    "validity": 3
  }
}

Note: retention is optional and if retention is desired, versioning must be enabled.

@cesnietor
Add retention option on bucket creation
c1b4cf2 
This also deletes a bucket if it was created and an error occurred
@cesnietor cesnietor self-assigned this Dec 11, 2020
bexsoft
bexsoft approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cesnietor cesnietor merged commit dd91c79 into minio:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft bexsoft approved these changes

@Alevsk Alevsk Awaiting requested review from Alevsk

Assignees

@cesnietor cesnietor

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cesnietor @dvaldivia @bexsoft