Fix all react warnings #507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested changes
Dec 14, 2020
| <Grid container> | ||
| <Grid item xs={12} className={classes.container}> | ||
| {error !== "" && ( | ||
| <Grid item xs={12}> |
Collaborator
There was a problem hiding this comment.
Please add the correct class name for error message
Collaborator
Author
There was a problem hiding this comment.
This is how we display errors in so many places XD do we have a component for errors?
Collaborator
There was a problem hiding this comment.
Not yet, but right now we are using a class called errorBlock
portal-ui/src/screens/Console/Buckets/ListBuckets/Objects/ObjectDetails/ShareFile.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Configurations/ConfigurationPanels/ConfigurationsList.tsx
Outdated
Show resolved
Hide resolved
Collaborator
|
I found another issue that seems not to be related to this change but must be fixed (#512) |
dvaldivia
force-pushed
the
fix-all-react-warnings
branch
from
068b272 to
81456cb
Compare
bexsoft
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all the outstanding warnings that react complains about.
Now
yarn buildcompletes without a complaint