Integrate retention option during bucket creation on UI #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested changes
Dec 14, 2020
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
Beside of component change, it is working good
| {enableRetention && ( | ||
| <React.Fragment> | ||
| <Grid item xs={12}> | ||
| <SelectWrapper |
Collaborator
There was a problem hiding this comment.
Can we please change this component to be a RadioSelectorGroup? To have more consistent forms
Collaborator
Author
There was a problem hiding this comment.
Can we please change this component to be a RadioSelectorGroup? To have more consistent forms
Comments addressed PTAL.
cesnietor
force-pushed
the
add-retention-bucket-ui
branch
from
30b6c4d to
ce73b32
Compare
dvaldivia
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/minio/console/issues/426
Test notes: It should create the bucket without issues only if versioning is enabled