Skip to content

Conversation

@cesnietor
Copy link
Collaborator

@cesnietor cesnietor commented Dec 17, 2020

fixes: https://github.com/minio/console/issues/415
Loading component [edited]:
Screen Shot 2020-12-17 at 7 44 11 PM

Also show notification component, shared across the application:
Screen Shot 2020-12-17 at 5 05 32 PM

dvaldivia
dvaldivia previously approved these changes Dec 17, 2020
@belvid
Copy link

belvid commented Dec 18, 2020

@cesnietor Can you make the loading line 1 pixel thicker? and also, can the unloaded part of the line be this color? #eaeaea

Thanks!

@cesnietor
Copy link
Collaborator Author

@cesnietor Can you make the loading line 1 pixel thicker? and also, can the unloaded part of the line be this color? #d9deea

Thanks!

done @belvid

@cesnietor cesnietor requested a review from dvaldivia December 18, 2020 01:49
belvid
belvid previously approved these changes Dec 18, 2020
Copy link

@belvid belvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working only for the first time, if I upload multiple files (one after another) the message it's only shown for the first file

Screen.Recording.2020-12-17.at.21.19.27-hevcmp4.mp4

@dvaldivia
Copy link
Collaborator

for me for large files it only fills until half

@cesnietor
Copy link
Collaborator Author

Seems to be working only for the first time, if I upload multiple files (one after another) the message it's only shown for the first file

Screen.Recording.2020-12-17.at.21.19.27-hevcmp4.mp4

fixed @bexsoft

@cesnietor
Copy link
Collaborator Author

for me for large files it only fills until half

@dvaldivia this might be the api, since it times out, I added a way to catch and display the error on the UI. This PR only changes UI. We might need to check the API to keep the connection alive.

@cesnietor cesnietor requested a review from bexsoft December 18, 2020 04:22
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Test OK

@dvaldivia dvaldivia merged commit 51ba86f into minio:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add progress bar when uploading a large object

4 participants