-
Notifications
You must be signed in to change notification settings - Fork 512
Add progress bar on UI #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cesnietor Can you make the loading line 1 pixel thicker? and also, can the unloaded part of the line be this color? #eaeaea Thanks! |
0f1bd3f to
3bd496d
Compare
done @belvid |
belvid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
bexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working only for the first time, if I upload multiple files (one after another) the message it's only shown for the first file
Screen.Recording.2020-12-17.at.21.19.27-hevcmp4.mp4
|
for me for large files it only fills until half |
3bd496d to
fff34fb
Compare
fixed @bexsoft |
@dvaldivia this might be the api, since it times out, I added a way to catch and display the error on the UI. This PR only changes UI. We might need to check the API to keep the connection alive. |
bexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Test OK
fixes: https://github.com/minio/console/issues/415

Loading component [edited]:
Also show notification component, shared across the application:
