Skip to content

Upgrade to Go 1.16. Remove Go-Bind-assets in favor of embed. #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 5, 2021
Merged

Upgrade to Go 1.16. Remove Go-Bind-assets in favor of embed. #630

merged 5 commits into from
Mar 5, 2021

Conversation

@dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Mar 4, 2021

Removes go-bindassets in favor of Go's embed package. This means the developer no longer needs to checking the large go-bindassets.go file but instead the delta from portal-ui/build/ in order to get the new files embedded into the compiled go binary for console.

@dvaldivia dvaldivia added UI User Interface operator Operator Console labels Mar 4, 2021
@dvaldivia dvaldivia self-assigned this Mar 4, 2021
harshavardhana
harshavardhana previously approved these changes Mar 4, 2021
View reviewed changes
bexsoft
bexsoft requested changes Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting the following error trying to build the binary:

Screen Shot 2021-03-04 at 18 41 25

@harshavardhana
Copy link
Member

harshavardhana commented Mar 5, 2021

I'm getting the following error trying to build the binary:

go mod tidy should fix this.

bexsoft
bexsoft approved these changes Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Test: OK

Alevsk
Alevsk approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@Alevsk Alevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine

@dvaldivia dvaldivia merged commit a2a09b8 into minio:master Mar 5, 2021
@dvaldivia dvaldivia deleted the go-embed branch March 5, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bexsoft bexsoft bexsoft approved these changes

@harshavardhana harshavardhana harshavardhana left review comments

@cesnietor cesnietor Awaiting requested review from cesnietor

+1 more reviewer

@Alevsk Alevsk Alevsk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dvaldivia dvaldivia

Labels

operator Operator Console UI User Interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dvaldivia @harshavardhana @Alevsk @bexsoft