Adding list of pods #715
Adding list of pods #715
Conversation
|
If I run other applications on the same namespace as the Tenant they get listed, please restrict the pods to only Tenant Pods
|
| {selectedTab === 2 && pods[0].time && ( | ||
| <TableWrapper | ||
| itemActions={[ | ||
| { |
There was a problem hiding this comment.
The delete action is not yet implemented, please remove this option
There was a problem hiding this comment.
You can send an empty array to item actions, it is not necessary to have an option here always
There was a problem hiding this comment.
You can send an empty array to item actions, it is not necessary to have an option here always
|
Can you also attach a screenshot of the final screen to this ticket |
| label?: string; | ||
| } | ||
|
|
||
| export interface IPod { |
There was a problem hiding this comment.
We should call it IPodListElement to have more clarity on what does this interface do
| result[i].time = niceDays( | ||
| (currentTime - parseInt(result[i].timecreated)).toString() | ||
| ); | ||
| console.log(result[i]); |
| {selectedTab === 2 && pods[0].time && ( | ||
| <TableWrapper | ||
| itemActions={[ | ||
| { |
There was a problem hiding this comment.
You can send an empty array to item actions, it is not necessary to have an option here always
| {selectedTab === 2 && pods[0].time && ( | ||
| <TableWrapper | ||
| itemActions={[ | ||
| { |
There was a problem hiding this comment.
You can send an empty array to item actions, it is not necessary to have an option here always
swagger.yml
Outdated
| status: | ||
| type: | ||
| string | ||
| timecreated: |
There was a problem hiding this comment.
Please use camel case:
| timecreated: | |
| timeCreated: |
swagger.yml
Outdated
| string | ||
| timecreated: | ||
| type: integer | ||
| podip: |
There was a problem hiding this comment.
Same camel case here:
| podip: | |
| podIP: |
| .then((result: IPod[]) => { | ||
| for (let i = 0; i < result.length; i++) { | ||
| let currentTime = new Date().getSeconds(); | ||
| console.log(currentTime); |
| let currentTime = new Date().getSeconds(); | ||
| console.log(currentTime); | ||
| result[i].time = niceDays( | ||
| (currentTime - parseInt(result[i].timecreated)).toString() |
There was a problem hiding this comment.
Not sure if this what is intended, as you are receiving an epoch time from backend and you are substracting the amount of seconds of current time:
restapi/admin_tenants.go
Outdated
| } | ||
| retval := []*models.TenantPod{} | ||
| for i := range pods.Items { | ||
| if pods.Items[i].Name[0:len(params.Tenant)] == params.Tenant { |
There was a problem hiding this comment.
I broke this logic by deploying a pod for wodpress with the tenant prefix
admin.json
Outdated
| @@ -0,0 +1,22 @@ | |||
| { | |||
restapi/admin_tenants.go
Outdated
| return nil, prepareError(err) | ||
| } | ||
| listOpts := metav1.ListOptions{ | ||
| TypeMeta: metav1.TypeMeta{}, |
There was a problem hiding this comment.
remove all unused fields, also this doesn't filter anything like we discussed
portal-ui/src/screens/Console/Tenants/TenantDetails/TenantDetails.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Tenants/TenantDetails/TenantDetails.tsx
Outdated
Show resolved
Hide resolved
…ils.tsx Co-authored-by: Alex <[email protected]>
…ils.tsx Co-authored-by: Alex <[email protected]>
4 participants
No description provided.