Move change user password modal #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created Icon button on UserDetails.tsx with drop down menu for Change User Password and Delete User prompts, removed pencil icon from ListUsers.tsx
bexsoft
requested changes
Jun 11, 2021
| return; | ||
| } | ||
|
|
||
| if (newPassword.length < 8) { |
Collaborator
There was a problem hiding this comment.
What is the difference between this component and ChangeUserPasswordModal?
Collaborator
There was a problem hiding this comment.
ChangePasswordModal is for the current user, which asks for current password and the other one is to change some other user's password
Collaborator
There was a problem hiding this comment.
Ok, I think it would be better to merge these two components into a single one, and just use a flag to show / hide fields, We can do this in a new PR
bexsoft
approved these changes
Jun 11, 2021
dvaldivia
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/miniohq/engineering/issues/158
What does this do?
Moved Change User Password feature to UserDetails page, located in an iconbutton accessed menu along with DeleteUser
How does it look?
