fix: GetAllCertificatesAndCAs shouldn't fail internally #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
update-to
branch
from
e5dc037 to
ccce356
Compare
all libraries in pkg/* should never called Fatal() internally, console is imported now and it is important that the failure logging etc are all well controlled. Bonus: update to latest minio/pkg v1.0.6 to get trial customer license verification fixes. Bonus do not exit inside
harshavardhana
force-pushed
the
update-to
branch
from
ccce356 to
3818303
Compare
Alevsk
approved these changes
Jun 11, 2021
Member
Author
|
Yo PTAL @Alevsk @dvaldivia @bexsoft |
dvaldivia
approved these changes
Jun 14, 2021
Alevsk
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all libraries in pkg/* should never called Fatal()
internally, console is imported now and it is important
that the failure logging etc are all well controlled.
Bonus: update to latest minio/pkg v1.0.6 to get trial
customer license verification fixes.