Moved Change User Password and added password length check #820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
reviewed
Jun 18, 2021
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
LGTM, waiting for Daniel's merge to approve
Alevsk
suggested changes
Jun 18, 2021
jinapurapu
force-pushed
the
move_changeUserPassword_modal
branch
from
8031a77 to
2362a29
Compare
dvaldivia
approved these changes
Jun 18, 2021
Alevsk
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Feature to change password for selected user moved to an Iconbutton on UserDetails.tsx, along with additional delete user function.
Password length checking with error message added to ChangeUserPassword, AccountChangePassword and AddUser modals
How does it look?