Make ElementKey optional #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested changes
Jun 23, 2021
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
Why are we trying to apply this change? TableWrapper is designed to receive an empty string when you are sending a list of string to render
dvaldivia
force-pushed
the
element-key-optional
branch
from
2040a64 to
3757f73
Compare
Signed-off-by: Daniel Valdivia <[email protected]>
bexsoft
previously approved these changes
Jun 23, 2021
dvaldivia
force-pushed
the
element-key-optional
branch
from
3757f73 to
fa79e72
Compare
bexsoft
approved these changes
Jun 23, 2021
Alevsk
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Valdivia [email protected]