Admin Trace UI - Revival #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alevsk
previously approved these changes
Apr 30, 2020
cesnietor
requested changes
Apr 30, 2020
dvaldivia
force-pushed
the
trace-ui-revival
branch
from
52fb565 to
9f9f1be
Compare
Alevsk
previously approved these changes
Apr 30, 2020
Collaborator
|
the assets seem not to be built |
dvaldivia
force-pushed
the
trace-ui-revival
branch
from
9f9f1be to
96b2793
Compare
Alevsk
approved these changes
Apr 30, 2020
bexsoft
requested changes
Apr 30, 2020
Comment on lines
+107
to
+125
| const units = ["B", "KB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"]; | ||
| const niceBytes = (x: string) => { | ||
| let l = 0, | ||
| n = parseInt(x, 10) || 0; | ||
|
|
||
| while (n >= 1024 && ++l) { | ||
| n = n / 1024; | ||
| } | ||
| //include a decimal point and a tenths-place digit if presenting | ||
| //less than ten of KB or greater units | ||
| return n.toFixed(n < 10 && l > 0 ? 1 : 0) + " " + units[l]; | ||
| }; | ||
| const timeFromdate = (d: Date) => { | ||
| let h = d.getHours() < 10 ? `0${d.getHours()}` : `${d.getHours()}`; | ||
| let m = d.getMinutes() < 10 ? `0${d.getMinutes()}` : `${d.getMinutes()}`; | ||
| let s = d.getSeconds() < 10 ? `0${d.getSeconds()}` : `${d.getSeconds()}`; | ||
|
|
||
| return `${h}:${m}:${s}:${d.getMilliseconds()}`; | ||
| }; |
Collaborator
There was a problem hiding this comment.
This can be placed in utils file
| const isDev = process.env.NODE_ENV === "development"; | ||
| const port = isDev ? "9090" : url.port; | ||
|
|
||
| const setCookie = (name: string, val: string) => { |
Collaborator
There was a problem hiding this comment.
This can be set in utils file too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.