Skip to content

Conversation

@dvaldivia
Copy link
Collaborator

This PR introduces the capability to host tenant console screens on the Operator UI via iframes. the proxy endpoint will authorize against the tenant and issue a cookie which is used for subsequent calls.

@dvaldivia dvaldivia self-assigned this Jul 13, 2021
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, Need to test

bexsoft
bexsoft previously approved these changes Jul 15, 2021
bexsoft
bexsoft previously approved these changes Jul 16, 2021
bexsoft
bexsoft previously approved these changes Jul 19, 2021
Copy link
Contributor

@Alevsk Alevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing it and reviewing the authentication model

bexsoft
bexsoft previously approved these changes Jul 19, 2021
Signed-off-by: Daniel Valdivia <[email protected]>
@Alevsk Alevsk self-requested a review July 20, 2021 18:27
Copy link
Contributor

@Alevsk Alevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, perfect

Perfection

@dvaldivia dvaldivia merged commit 804e3b0 into minio:master Jul 20, 2021
@dvaldivia dvaldivia deleted the iframe-support branch July 20, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants