fix: properly support FS/Gateway mode #874
Merged
+51
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
update-madmin
branch
2 times, most recently
from
179765d to
c88f6ea
Compare
harshavardhana
force-pushed
the
update-madmin
branch
from
c88f6ea to
31df8cc
Compare
7 tasks
Alevsk
previously approved these changes
Jul 19, 2021
Member
Author
|
More changes this PR needs is UI Elements need to be turned off if certain backend is chosen. I am not aware of how to do that @dvaldivia @bexsoft |
Collaborator
I will start working on that today @harshavardhana, in this case we will just need to return a flag during login and send it in the response so we can enable or disable items like we do with IAM |
bexsoft
previously approved these changes
Jul 19, 2021
harshavardhana
force-pushed
the
update-madmin
branch
from
4587970 to
4eb8b5e
Compare
Member
Author
|
PTAL @Alevsk @dvaldivia |
dvaldivia
approved these changes
Jul 19, 2021
Collaborator
|
Tested. LGTM |
bexsoft
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/minio/console/issues/723