Skip to content

Conversation

@dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Jul 19, 2021

Fixes https://github.com/miniohq/engineering/issues/184

To test, upload a file called 02%20-%20FLY%20ME%20TO%20THE%20MOON%20.mp3 which now is supported from the Upload on the UI, then delete it.

Also support unicode now: 新文章.txt

Signed-off-by: Daniel Valdivia [email protected]

@dvaldivia dvaldivia added the bug this needs to be fixed label Jul 19, 2021
@dvaldivia dvaldivia self-assigned this Jul 19, 2021
@dvaldivia dvaldivia force-pushed the fix-delete-object-bug branch from 0bdb824 to 4568bdf Compare July 20, 2021 22:22
harshavardhana
harshavardhana previously approved these changes Jul 20, 2021
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for now.

@dvaldivia dvaldivia force-pushed the fix-delete-object-bug branch from 31cdd7d to bc517b7 Compare July 20, 2021 22:41
Signed-off-by: Daniel Valdivia <[email protected]>
Copy link
Contributor

@adfost adfost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvaldivia dvaldivia merged commit c31af8b into minio:master Jul 21, 2021
@dvaldivia dvaldivia deleted the fix-delete-object-bug branch July 21, 2021 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug this needs to be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants