Skip to content

Conversation

@dvaldivia
Copy link
Collaborator

Fixes a bug preventing file uploads under hop and also passing query params which was making it so object details were not showing versions

Signed-off-by: Daniel Valdivia [email protected]

@dvaldivia dvaldivia self-assigned this Aug 2, 2021
@harshavardhana
Copy link
Member

Does this change allow for running console under a separate prefix? @dvaldivia

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue during file upload under port :9090 & :5000, with. big files an error in blue is thrown. With small files it says that file was uploaded successfully, but file doesn't appear in the list. No errors are seen in server or MinIO

Screen Shot 2021-08-02 at 19 02 24

Screen Shot 2021-08-02 at 19 01 44

bexsoft
bexsoft previously approved these changes Aug 3, 2021
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana
Copy link
Member

Does this change allow for running console under a separate prefix? @dvaldivia

@dvaldivia ^^?

@dvaldivia
Copy link
Collaborator Author

Yes @harshavardhana

@harshavardhana
Copy link
Member

Yes @harshavardhana

Can you document this behavior and also fix the title of this PR - we can't tell if that is what you are supporting here.

It will help @ravindk89 document this properly for k8s environments basically now we can have

MINIO_SERVER_URL=https://ingress.example.com
MINIO_BROWSER_REDIRECT_URL=https://ingress.example.com/console

@dvaldivia
Copy link
Collaborator Author

@harshavardhana it's fixing a problem where the hop screen from operator UI was not passing query parameters, and also the file upload was not working in this mode

@ravindk89
Copy link
Contributor

For my understanding:

Starting in the next Console release, you can do:

MINIO_SERVER_URL=https://ingress.example.com
MINIO_BROWSER_REDIRECT_URL=https://ingress.example.com/console

For prior Console releases, what is the behavior? Is the expectation there for MINIO_BROWSER_REDIRECT_URL to match MINIO_SERVER_URL ? It would be ideal for us to track both, as there will be users who cautiously upgrade and will need to know what the correct behavior is for their specific version.

@dvaldivia
Copy link
Collaborator Author

@ravindk89 not starting on the next release but soon, we still need to test console running on a subdirectory

@ravindk89
Copy link
Contributor

OK - so what is the current expected behavior with these envvars? cc @harshavardhana - trying to keep this straight, its a bit confusing.

@dvaldivia
Copy link
Collaborator Author

@ravindk89 so this PR is only about fixing a couple of bugs regarding the hop screen, on a separate PR we can complete the setup of running it on a subfolder, so let's not announce it yet

Alevsk
Alevsk previously approved these changes Aug 3, 2021
@dvaldivia dvaldivia dismissed stale reviews from Alevsk and bexsoft via 0218cc8 August 4, 2021 18:32
@dvaldivia dvaldivia merged commit e5dc8fe into minio:master Aug 4, 2021
@dvaldivia dvaldivia deleted the fix-hop-upload branch August 4, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants