-
Notifications
You must be signed in to change notification settings - Fork 512
Fix Hop File Upload and Query Params #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Does this change allow for running console under a separate prefix? @dvaldivia |
bexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dvaldivia ^^? |
|
Yes @harshavardhana |
Can you document this behavior and also fix the title of this PR - we can't tell if that is what you are supporting here. It will help @ravindk89 document this properly for k8s environments basically now we can have MINIO_SERVER_URL=https://ingress.example.com |
|
@harshavardhana it's fixing a problem where the hop screen from operator UI was not passing query parameters, and also the file upload was not working in this mode |
|
For my understanding: Starting in the next Console release, you can do: For prior Console releases, what is the behavior? Is the expectation there for |
|
@ravindk89 not starting on the next release but soon, we still need to test console running on a subdirectory |
|
OK - so what is the current expected behavior with these envvars? cc @harshavardhana - trying to keep this straight, its a bit confusing. |
|
@ravindk89 so this PR is only about fixing a couple of bugs regarding the hop screen, on a separate PR we can complete the setup of running it on a subfolder, so let's not announce it yet |
Signed-off-by: Daniel Valdivia <[email protected]>
efb35b7 to
0218cc8
Compare


Fixes a bug preventing file uploads under hop and also passing query params which was making it so object details were not showing versions
Signed-off-by: Daniel Valdivia [email protected]