Added pre validation of prometheus URL #956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Aug 17, 2021
bexsoft
force-pushed
the
prometheus-timeout-issue
branch
from
e8a5210 to
ae120bf
Compare
dvaldivia
previously approved these changes
Aug 17, 2021
harshavardhana
requested changes
Aug 17, 2021
Signed-off-by: Benjamin Perez <[email protected]>
bexsoft
force-pushed
the
prometheus-timeout-issue
branch
from
ae120bf to
4597072
Compare
dvaldivia
approved these changes
Aug 17, 2021
harshavardhana
approved these changes
Aug 17, 2021
TomHellier
pushed a commit
to TomHellier/console
that referenced
this pull request
Aug 20, 2021
Signed-off-by: Benjamin Perez <[email protected]>
|
Hey guys, new validation broke integration with VictoriaMetrics, which is Prometheus compatible database, but unfortunately doesn't have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #947
What does this do?
Adds a pre-validation to prometheus URL, so we can avoid long timeouts & unnecessary requests that will fail if URL is unreachable
How does it look?