Skip to content

docs: fixed broken build icon and added license link #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

Radovenchyk
Copy link
Contributor

Description

Related Issue

Type of Change

  • Bug fix 🐛
  • New feature 🚀
  • Breaking change 🚨
  • Documentation update 📖
  • Refactor 🔨
  • Other (please describe) ⬇️

Screenshots (if applicable e.g before/after)

Checklist

  • I have tested these changes
  • I have updated relevant documentation (if applicable)
  • I have added necessary unit tests (if applicable)

Test Steps

Additional Notes / Context

@@ -1,6 +1,6 @@
# MinIO Operator

![build](https://github.com/minio/operator/workflows/Go/badge.svg) ![license](https://img.shields.io/badge/license-AGPL%20V3-blue)
[![build](https://img.shields.io/badge/build-passing-green.svg)](https://github.com/minio/operator/actions) [![license](https://img.shields.io/badge/license-AGPL%20V3-blue)](https://github.com/minio/operator/blob/master/LICENSE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why nest the link?

Copy link
Contributor Author

@Radovenchyk Radovenchyk Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ramondeklein I think they should be there, all projects that use icons have a link to them. If you think they are unnecessary, then it might be better to remove them altogether.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the README.md file by updating broken build status badges and adding clickable links for better user experience.

  • Replaced broken GitHub Actions workflow badge with a generic build status badge
  • Added clickable links to both build status and license badges

@@ -1,6 +1,6 @@
# MinIO Operator

![build](https://github.com/minio/operator/workflows/Go/badge.svg) ![license](https://img.shields.io/badge/license-AGPL%20V3-blue)
[![build](https://img.shields.io/badge/build-passing-green.svg)](https://github.com/minio/operator/actions) [![license](https://img.shields.io/badge/license-AGPL%20V3-blue)](https://github.com/minio/operator/blob/master/LICENSE)
Copy link
Preview

Copilot AI Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build badge now uses a static 'passing' status instead of the dynamic GitHub Actions workflow badge. This means the badge will always show 'passing' regardless of actual build status, which could be misleading. Consider using the correct GitHub Actions badge format: [![build](https://github.com/minio/operator/actions/workflows/go.yml/badge.svg)](https://github.com/minio/operator/actions) or similar.

Suggested change
[![build](https://img.shields.io/badge/build-passing-green.svg)](https://github.com/minio/operator/actions) [![license](https://img.shields.io/badge/license-AGPL%20V3-blue)](https://github.com/minio/operator/blob/master/LICENSE)
[![build](https://github.com/minio/operator/actions/workflows/go.yml/badge.svg)](https://github.com/minio/operator/actions) [![license](https://img.shields.io/badge/license-AGPL%20V3-blue)](https://github.com/minio/operator/blob/master/LICENSE)

Copilot uses AI. Check for mistakes.

@pjuarezd pjuarezd merged commit d3e77e0 into minio:master Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants