-
Notifications
You must be signed in to change notification settings - Fork 487
docs: fixed broken build icon and added license link #2468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,6 +1,6 @@ | |||
# MinIO Operator | |||
|
|||
  | |||
[](https://github.com/minio/operator/actions) [](https://github.com/minio/operator/blob/master/LICENSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why nest the link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ramondeklein I think they should be there, all projects that use icons have a link to them. If you think they are unnecessary, then it might be better to remove them altogether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the README.md file by updating broken build status badges and adding clickable links for better user experience.
- Replaced broken GitHub Actions workflow badge with a generic build status badge
- Added clickable links to both build status and license badges
@@ -1,6 +1,6 @@ | |||
# MinIO Operator | |||
|
|||
  | |||
[](https://github.com/minio/operator/actions) [](https://github.com/minio/operator/blob/master/LICENSE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build badge now uses a static 'passing' status instead of the dynamic GitHub Actions workflow badge. This means the badge will always show 'passing' regardless of actual build status, which could be misleading. Consider using the correct GitHub Actions badge format: [](https://github.com/minio/operator/actions)
or similar.
[](https://github.com/minio/operator/actions) [](https://github.com/minio/operator/blob/master/LICENSE) | |
[](https://github.com/minio/operator/actions) [](https://github.com/minio/operator/blob/master/LICENSE) |
Copilot uses AI. Check for mistakes.
Description
Related Issue
Type of Change
Screenshots (if applicable e.g before/after)
Checklist
Test Steps
Additional Notes / Context