Mount certificates to Console container under /tmp/certs #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed --tls-cert and --tls-key flags from console because they are not need it anymore - added --certs-dir flag to console server so we take advantage of the sni feature
cesnietor
approved these changes
Nov 4, 2020
Contributor
cesnietor
left a comment
cesnietor
left a comment
There was a problem hiding this comment.
tested, now master console is being deployed correctly.
harshavardhana
approved these changes
Nov 10, 2020
jmontleon
pushed a commit
to jmontleon/operator
that referenced
this pull request
Jul 23, 2024
system generated tasks should run at default priority (0). Signed-off-by: Jeff Ortel <[email protected]>
jmontleon
pushed a commit
to jmontleon/operator
that referenced
this pull request
Jul 23, 2024
system generated tasks should run at default priority (0). Signed-off-by: Jeff Ortel <[email protected]> Co-authored-by: Jeff Ortel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not need it anymore
sni feature