This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Download notarization log, parse issues, error if any issues #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a really sad thing discovered pursuing #5.
It turns out that the notarization status can be "success" and there can be "warnings" in the issues list in the log. If there are warnings, Gatekeeper still fails to validate a package and it won't launch.
This PR introduces the ability to download and parse logs, and errors if there are any issues (including warnings). We also output these directly in the CLI now which is nice. If we fail to download the log, we consider notarization a failure.
I wanted to add more tests for this but wanted to get this merged in quickly since its blocking us in some ways. I'll add tests in future commits.