Skip to content

Fix Provide More Info dialog to save to profile #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix Provide More Info dialog to save to profile #2983

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec77c76
adding missing fields
annagav Sep 29, 2025
9ec7b95
add last name too
annagav Sep 30, 2025
1902e7d
format
annagav Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 84 additions & 54 deletions frontend/public/src/components/forms/ProfileFormFields.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,70 @@ const findStates = (country: string, countries: Array<Country>) => {
null
}

const renderFirstNameField = errors => {
const hasError =
errors && errors.legal_address && errors.legal_address.first_name
return (
<div>
<CardLabel
htmlFor="legal_address.first_name"
isRequired={true}
label="First Name"
subLabel="Name that will appear on emails"
/>
<Field
type="text"
name="legal_address.first_name"
id="legal_address.first_name"
className="form-control"
autoComplete="given-name"
aria-invalid={hasError ? "true" : null}
aria-describedby={hasError ? "first-name-error" : null}
aria-description="Name cannot start with, or contain, a special character"
title="Name cannot start with, or contain, a special character."
required
/>
<ErrorMessage
id="first-name-error"
name="legal_address.first_name"
component={FormError}
/>
</div>
)
}

const renderLastNameField = errors => {
const hasError =
errors && errors.legal_address && errors.legal_address.last_name
return (
<div>
<CardLabel
htmlFor="legal_address.last_name"
isRequired={true}
label="Last Name"
subLabel="Name that will appear on emails"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this subLabel is correct. Can we just omit it, like we do on https://mitxonline.mit.edu/create-profile/

/>
<Field
type="text"
name="legal_address.last_name"
id="legal_address.last_name"
className="form-control"
autoComplete="family-name"
aria-invalid={hasError ? "true" : null}
aria-describedby={hasError ? "last-name-error" : null}
aria-description="Name cannot start with, or contain, a special character"
title="Name cannot start with, or contain, a special character."
required
/>
<ErrorMessage
id="last-name-error"
name="legal_address.last_name"
component={FormError}
/>
</div>
)
}

const renderYearOfBirthField = errors => {
const hasError =
errors && errors.user_profile && errors.user_profile.year_of_birth
Expand Down Expand Up @@ -202,8 +266,20 @@ export const LegalAddressCountryFields = ({
values.legal_address.country === "CA") &&
!values.legal_address.state)
)
const [showFirstNameField, setShowFirstNameField] = React.useState(
values.legal_address.first_name === ""
)
const [showLastNameField, setShowLastNameField] = React.useState(
values.legal_address.last_name === ""
)

React.useEffect(() => {
if (values.legal_address.first_name === "") {
setShowFirstNameField(true)
}
if (values.legal_address.last_name === "") {
setShowLastNameField(true)
}
if (values.user_profile.year_of_birth === "") {
setShowYearOfBirthField(true)
}
Expand All @@ -219,6 +295,12 @@ export const LegalAddressCountryFields = ({

return (
<React.Fragment>
{showFirstNameField ? (
<div className="form-group">{renderFirstNameField(errors)}</div>
) : null}
{showLastNameField ? (
<div className="form-group">{renderLastNameField(errors)}</div>
) : null}
{showYearOfBirthField ? (
<div className="form-group">{renderYearOfBirthField(errors)}</div>
) : null}
Expand Down Expand Up @@ -316,60 +398,8 @@ export const LegalAddressFields = ({
const addressErrors = errors && errors.legal_address
return (
<React.Fragment>
<div className="form-group">
<CardLabel
htmlFor="legal_address.first_name"
isRequired={true}
label="First Name"
subLabel="Name that will appear on emails"
/>
<Field
type="text"
name="legal_address.first_name"
id="legal_address.first_name"
className="form-control"
autoComplete="given-name"
aria-invalid={
addressErrors && addressErrors.first_name ? "true" : null
}
aria-describedby={
addressErrors && addressErrors.first_name ?
"first-name-error" :
null
}
aria-description="Name cannot start with, or contain, a special character"
title="Name cannot start with, or contain, a special character."
required
/>
<ErrorMessage
id="first-name-error"
name="legal_address.first_name"
component={FormError}
/>
</div>
<div className="form-group">
<CardLabel
htmlFor="legal_address.last_name"
isRequired={true}
label="Last Name"
/>
<Field
type="text"
name="legal_address.last_name"
id="legal_address.last_name"
className="form-control"
autoComplete="family-name"
aria-invalid={
addressErrors && addressErrors.last_name ? "true" : null
}
aria-describedby={
addressErrors && addressErrors.last_name ? "last-name-error" : null
}
aria-description="Name cannot start with, or contain, a special character"
required
/>
<ErrorMessage name="legal_address.last_name" component={FormError} />
</div>
<div className="form-group">{renderFirstNameField(errors)}</div>
<div className="form-group">{renderLastNameField(errors)}</div>
<div className="form-group">
<CardLabel
htmlFor="name"
Expand Down
Loading