Skip to content

fix: use global id for user sync filtering #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2025
Merged

fix: use global id for user sync filtering #2992

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f7812e
fix: use global id for user sync filtering
asajjad2 Oct 3, 2025
a6db31a
feat: add login check to hubspot user sync
asajjad2 Oct 9, 2025
0598cfe
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions hubspot_sync/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,12 @@ def batch_upsert_hubspot_objects( # pylint:disable=too-many-arguments # noqa:
id__in=[id[0] for id in synced_object_ids] # noqa: A001
)
if model_name == "user":
unsynced_objects = (
unsynced_objects.filter(is_active=True, email__contains="@")
.exclude(social_auth__isnull=True)
.order_by(F("hubspot_sync_datetime").asc(nulls_first=True))
)
unsynced_objects = unsynced_objects.filter(
is_active=True,
email__contains="@",
global_id__isnull=False,
last_login__isnull=False,
).order_by(F("hubspot_sync_datetime").asc(nulls_first=True))
unsynced_object_ids = unsynced_objects.values_list("id", flat=True)
object_ids = unsynced_object_ids if create else synced_object_ids
elif not create:
Expand Down