Skip to content

[VIRTS-2000] Obfuscators v2 API #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2021
Merged

Conversation

bleepbop
Copy link
Contributor

Description

Created new Obfuscators v2 API, supporting the following endpoints:

  • GET /api/v2/obfuscators
  • GET /api/v2/obfuscators/:id

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Using Postman, these endpoints were tested with red/blue users.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #2188 (93660dd) into master (e0c652f) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2188      +/-   ##
==========================================
- Coverage   69.13%   69.11%   -0.03%     
==========================================
  Files          83       83              
  Lines        6133     6138       +5     
==========================================
+ Hits         4240     4242       +2     
- Misses       1893     1896       +3     
Impacted Files Coverage Δ
app/api/v2/__init__.py 9.09% <0.00%> (-0.91%) ⬇️
app/objects/c_obfuscator.py 91.42% <66.66%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0c652f...93660dd. Read the comment docs.

@bleepbop bleepbop marked this pull request as ready for review June 28, 2021 20:09
@bleepbop bleepbop changed the title [Draft] [VIRTS-2000] Obfuscators v2 API [VIRTS-2000] Obfuscators v2 API Jun 28, 2021
@bleepbop bleepbop requested a review from uruwhy June 28, 2021 20:09
Copy link
Contributor

@uruwhy uruwhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - endpoints work as expected when fetching obfuscators

@bleepbop bleepbop requested a review from wbooth July 1, 2021 19:13
@bleepbop bleepbop merged commit ff68cce into master Jul 6, 2021
@bleepbop bleepbop deleted the bleepbop/VIRTS-2000/obfuscators-api branch July 6, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants