-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Utc time #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…1 format in the GUI. Also increasing dead/alive threshold by 500ms Convert agent timestamps back to local timezone when doing comparisons for op start time Converting timestamps to UTC
Codecov Report
@@ Coverage Diff @@
## master #2355 +/- ##
==========================================
- Coverage 72.60% 72.59% -0.01%
==========================================
Files 110 110
Lines 7946 7947 +1
==========================================
Hits 5769 5769
- Misses 2177 2178 +1
Continue to review full report at Codecov.
|
SonarCloud Quality Gate failed.
|
Description
Converting timestamps in CALDERA to be UTC-based rather than based on the timezone of the server. This change will allow timestamps to be normalized regardless of whether or not users are accessing the C2 server from browsers in different timezones. Timestamps outputted in the GUI and operation reports will also be in UTC in 2021-11-10T13:14:15Z format.
Will require the sandcat agent to update how it sends timestamps back to the C2 server upon completing actions - right now, the agent reports local times, which can vary depending on the timezones of the targeted hosts. There will also be associated gocat/sandcat PRs to handle this.
Associated gocat PR: mitre/gocat#70
For plugins that use timestamps, such as training and debrief, subsequent PRs for those specific plugins will be needed.
Documentation will need to be updated to specify UTC timestamps and to replace timestamps in examples with UTC.
Type of change
How Has This Been Tested?
Updated pytest unit tests accordingly.
Also ran several operations, both scheduled and unscheduled. All operations were performed with one agent in the same timezone as the C2 server and with another agent in a timezone two hours ahead. Agent/operation data was checked via operation report JSON and API data dumps to verify the outputted timestamps. Operations were generated both via the GUI and API, both from the same timezone and from a timezone 2 hours ahead (e.g. C2 server was running at UTC-5, and the operations were started from a VM in UTC-3).
Checklist: