Skip to content

Makes Docker directly handle the SIGINT signal #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jbaptperez
Copy link
Contributor

Description

Caldera needs the SIGINT signal to be properly stopped.
As Docker defaults to the SIGTERM signal, a workaround was, until now, to manually send the SIGINT signal.

This PR makes the Docker image directly set the signal tu use when stopping a related container.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Building a new image and invoking docker stop <container-id> instead of docker kill --signal=SIGINT <container-id>.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@elegantmoose
Copy link
Contributor

@clenk Im fine with this. Thoughts?

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clenk clenk merged commit 8d67374 into mitre:master Jun 6, 2024
@jbaptperez jbaptperez deleted the docker-signal branch June 9, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants