Skip to content

Conversation

@alamb
Copy link

@alamb alamb commented May 21, 2025

I wanted to see what avoiding strum and Cow would do to the API in the variant Read API, so I tried it out:

@mkarbo
Copy link
Owner

mkarbo commented May 22, 2025

Nice, thank you!

I am OK with the Cow removal, we can assess whether we want to re-add it when we do the builder API later, we were worried about the inability to have an owned variant, but let's see if it becomes an issue - it's easy to re-add.

Will also comment this on my PR reg. Cow

@mkarbo mkarbo merged commit 9aa5d3b into mkarbo:mkar/7423-read-variant-api May 22, 2025
@alamb alamb deleted the alamb/no_strum branch May 22, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants