Skip to content

Conversation

rynoV
Copy link
Contributor

@rynoV rynoV commented Jul 9, 2022

Resolves #16, also see comments there.

I'm not sure this is an ideal solution, but it's quick and better than what we're doing currently (fetching everything just to get one NFT). I'll write down possible improvements in #31, but it's probably not high priority.

@rynoV rynoV marked this pull request as draft July 9, 2022 21:52
@rynoV rynoV changed the title Fetch NFT initial implementation Contract to fetch single NFT Jul 9, 2022
@rynoV rynoV self-assigned this Jul 9, 2022
@rynoV rynoV added the enhancement New feature or request label Jul 9, 2022
@rynoV rynoV linked an issue Jul 9, 2022 that may be closed by this pull request
Base automatically changed from calum/optimize-list-nft to neil/typescript-api July 11, 2022 16:24
@rynoV rynoV force-pushed the calum/fetch-single-nft branch from edd780a to 03652be Compare July 23, 2022 16:56
@rynoV rynoV marked this pull request as ready for review July 23, 2022 16:57
@rynoV rynoV force-pushed the calum/fetch-single-nft branch from 03652be to d55f2a7 Compare July 23, 2022 17:07
@rynoV rynoV force-pushed the calum/fetch-single-nft branch from d55f2a7 to bfcf8a6 Compare July 23, 2022 17:07
@samuelWilliams99
Copy link
Contributor

If this is verified working, happy to merge

@samuelWilliams99 samuelWilliams99 merged commit 8798232 into neil/typescript-api Jul 25, 2022
@samuelWilliams99 samuelWilliams99 deleted the calum/fetch-single-nft branch July 25, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement contract for fetching a single NFT

2 participants