Skip to content

[Fix] fix a typo in event_trace_recorder #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2024
Merged

[Fix] fix a typo in event_trace_recorder #2253

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d3c5e3
Fix typo in event_tracer
Kevin-XiongC Apr 30, 2024
6d77efe
[Fix] fix a typo in event_tracer
Kevin-XiongC Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/serve/event_trace_recorder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class EventTraceRecorderImpl : public EventTraceRecorderObj {
void AddEvent(const Array<String>& request_ids, const std::string& event) final {
double event_time = std::chrono::duration_cast<std::chrono::duration<double>>(
std::chrono::system_clock::now().time_since_epoch())
.count();
.count(); // in seconds

{
std::lock_guard<std::mutex> lock(mutex_);
Expand Down Expand Up @@ -96,16 +96,16 @@ class EventTraceRecorderImpl : public EventTraceRecorderObj {
name = event;
phase = "i";
}
int64_t event_time_in_ms = static_cast<int64_t>(event_time * 1e6);
int64_t event_time_in_us = static_cast<int64_t>(event_time * 1e6);

picojson::object event_json;
event_json["name"] = picojson::value(name);
event_json["ph"] = picojson::value(phase);
event_json["ts"] = picojson::value(event_time_in_ms);
event_json["ts"] = picojson::value(event_time_in_us);
event_json["pid"] = picojson::value(static_cast<int64_t>(1));
event_json["tid"] = picojson::value(request_id);

events_to_sort.push_back({event_time_in_ms, picojson::value(event_json)});
events_to_sort.push_back({event_time_in_us, picojson::value(event_json)});
}
std::sort(events_to_sort.begin(), events_to_sort.end(), fcmp_events);
for (auto [timestamp, event] : events_to_sort) {
Expand Down