Add support for gemma3_instruction to genconfig #3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterJH5574
approved these changes
Jun 30, 2025
gururajkosuru
added a commit
to gururajkosuru/mlc-llm
that referenced
this pull request
Oct 14, 2025
This PR adds comprehensive unit tests for the Gemma3 model architecture, which was added in mlc-ai#3172, mlc-ai#3178, mlc-ai#3224 but lacked test coverage. Changes: - Add tests/python/model/test_gemma3.py with the following test cases: * test_gemma3_model_registered: Verify model is in registry * test_gemma3_creation: Test model creation and TVM export * test_gemma3_config_validation: Validate configuration parameters - Tests cover gemma3_2b and gemma3_9b variants - Follows pattern from test_llama.py Testing: All tests pass locally (instructions in PR description for reproduction) Part of effort to add test coverage for recently added models.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
gemma3_instructionas a valid conversation template ingen_config.py, enabling the generation of config and manual compilation for the Gemma3 instruction model.