icon color: bluesky, instagram, threads, tiktok, x, youtube #5103
Conversation
| @@ -22,6 +22,7 @@ <h3 class="author__name p-name" itemprop="name"> | |||
| {% endif %} | |||
| </div> | |||
|
|
|||
| {% if author %} | |||
There was a problem hiding this comment.
This change is unnecessary. We're already using {% if author.avatar %} above, so either the build errors out, or this check always passes.
There was a problem hiding this comment.
Regardless of author.avatar's conditional statement.
The intention is to prevent the following phenomenon.
[Intended situation]
- I want to mark the avatar.
- I don't want to show links.
[Actual results]
- Avatar is displayed. (It's OK)
- Links are not displayed. (It's OK)
- However, when the screen is reduced, the 'Follow' button is displayed for no use.' (Why?)
- Even if I click the 'Follow' button, there are no links to display, so I only see empty spaces. (Why?)
[Conclusion]
In the end, the phrase {%ifauthor%} was used to turn on/off the "url wrapper" that determines the "follow" button display.
If there is a better way, it doesn't matter if you write another conditional statement.
What I wanted to do was disable url wrapper because if there is no information to follow, such as links and sns accounts, there is no reason for the 'follow' button to be displayed.
There was a problem hiding this comment.
I'm still not convinced this will work as intended. For {% if author %} to fail, you must omit the entire author key (so it evaluates to nil). In this case, there's no way to display an avatar.
_sass/minimal-mistakes/_page.scss
Outdated
| @@ -2,560 +2,565 @@ | |||
| SINGLE PAGE/POST | |||
| ========================================================================== */ | |||
|
|
|||
| #main { | |||
There was a problem hiding this comment.
Changes in this file are incomprehensible. Please revert.
There was a problem hiding this comment.
Something seems a little strange.
It was the 92nd line I was going to add the code below.
h2:first-of-type {
margin-top: 0em;
}
The reason why I need to put that setting in is as follows.
[AS-IS]
The height of the profile panel on the left and the TOC panel on the right are the same, but the height of the content panel in the middle is slightly lower.
This is because the margin-top of the h2 tag is applied.
The margin-top of the h2 tag should be applied from the use of the second h2 tag.
[TO-BE]
The margin-top of h2 used for the first time on the intermediate content panel shall not be set.
There was a problem hiding this comment.
But the git diff is still incomprehensible. Please revert the unnecessary part and make sure the diff accurately reflects your changes.
There was a problem hiding this comment.
Also, :first-of-type might not be as appropriate as :first-child, in case the content starts with something else. For example, I usually start my blog article with a regular paragraph.
There was a problem hiding this comment.
Then how about this?
/* vertical alignment for first content */
:first-child,
aside + :nth-child(2) {
margin-top: 0em;
}
|
|
||
| /* vertical alignment for first content */ | ||
| :first-child, | ||
| aside + :nth-child(2) { |
There was a problem hiding this comment.
These two three lines are over-indented by 2 spaces (1 level).
This is an enhancement or feature.
Summary
Positioned the brand icon below in alphabetical order
Added color for the brand icon below
Modified the color for the brand icon below
Added a square class to the brand icon below
Color crashed for the brand icon below, so I consolidated it into one setting