-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Move development dependencies into a dependency group (no more extra) #13452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2611486
Move development dependencies into a dependency group (no more extra)
hoechenberger 3717d3e
[autofix.ci] apply automated fixes
autofix-ci[bot] 2309d4c
Ensure latest pip
hoechenberger facfafa
Merge branch 'dep-groups' of https://github.com/hoechenberger/mne-pyt…
hoechenberger 59ab40f
Debug: get raw command output
hoechenberger 5c6a805
Update pyproject.toml
hoechenberger 341d280
Style
hoechenberger c51976c
Debug debug debug!
hoechenberger 655a8f8
I think I found it
hoechenberger fc0a81a
Install groups via `--group` (first small step)
hoechenberger c11ed08
Be more explicit / cleanup
hoechenberger c61dc13
Fix for Azure
hoechenberger dae46fc
Fix for CircleCI
hoechenberger 456a285
Update contribution guide
hoechenberger 2a4a3f2
But wait… there's more!
hoechenberger 510c805
Got one too many!
hoechenberger 33130cf
Fix for empty extras
hoechenberger 9e9fc7f
Fix unit test
hoechenberger 4cd1b57
Simpler test, like what we have in `main`
hoechenberger cd65a53
Merge branch 'main' into dep-groups
larsoner 16442fe
FIX: Move to req file
larsoner d262732
FIX: More
larsoner 07e2c18
FIX: Comment
larsoner a5b5f00
Merge remote-tracking branch 'upstream/main' into dep-groups
larsoner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Removed development dependencies from user-visible "extras"; they're now dependency | ||
| groups only visible to developers (and can be installed for example via | ||
| ``pip install --group dev`` with pip version 25.1 or later), by `Richard Höchenberger`_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # cross-domain-saliency-maps requirements are onerous (torch and tensorflow) | ||
| # so we don't add it here, and install it separately in circleci_dependencies.sh | ||
| alphaCSC | ||
| autoreject | ||
| bycycle | ||
| conpy | ||
| curryreader | ||
| eeg_positions | ||
| emd | ||
| fooof | ||
| meegkit | ||
| meggie | ||
| mne-ari | ||
| mne-bids-pipeline | ||
| mne-faster | ||
| mne-features | ||
| mne-icalabel | ||
| mne-lsl | ||
| mne-microstates | ||
| mne-nirs | ||
| mne-rsa | ||
| mnelab | ||
| neurodsp | ||
| neurokit2 | ||
| niseq | ||
| nitime | ||
| pactools | ||
| plotly | ||
| pycrostates | ||
| pyprep | ||
| pyriemann | ||
| python-picard | ||
| sesameeg | ||
| sleepecg | ||
| tensorpac | ||
| wfdb | ||
| yasa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,74 @@ | |
| build-backend = "hatchling.build" | ||
| requires = ["hatch-vcs", "hatchling"] | ||
|
|
||
| [dependency-groups] | ||
| dev = ["pip >= 25.1", "rcssmin", {include-group = "doc"}, {include-group = "test_extra"}] | ||
| # Dependencies for building the documentation | ||
| doc = [ | ||
| "graphviz", | ||
| "intersphinx_registry >= 0.2405.27", | ||
| "ipython != 8.7.0", # also in "full-no-qt" and "test" | ||
| "memory_profiler", | ||
| "mne-bids", | ||
| "mne-connectivity", | ||
| "mne-gui-addons", | ||
| "neo", | ||
| "numpydoc", | ||
| "openneuro-py", | ||
| "psutil", | ||
| "pydata_sphinx_theme >= 0.15.2", | ||
| "pygments >= 2.13", | ||
| "pytest", | ||
| "pyxdf", | ||
| "pyzmq != 24.0.0", | ||
| "seaborn != 0.11.2", | ||
| "selenium >= 4.27.1", | ||
| "sphinx >= 6", | ||
| "sphinx-design", | ||
| "sphinx-gallery >= 0.16", | ||
| "sphinx_copybutton", | ||
| "sphinxcontrib-bibtex >= 2.5", | ||
| "sphinxcontrib-towncrier >=0.5.0a0", | ||
| "sphinxcontrib-youtube", | ||
| ] | ||
| test = [ | ||
| "codespell", | ||
| "flaky", | ||
| "ipython != 8.7.0", # for testing notebook backend; also in "full-no-qt" and "doc" | ||
| "mypy", | ||
| "numpydoc", | ||
| "pre-commit", | ||
| "pytest >= 8.0", | ||
| "pytest-cov", | ||
| "pytest-qt", | ||
| "pytest-timeout", | ||
| "ruff", | ||
| "toml-sort", | ||
| "tomli; python_version<'3.11'", | ||
| "twine", | ||
| "vulture", | ||
| "wheel", | ||
| ] | ||
| # Dependencies for being able to run additional tests (rare/CIs/advanced devs) | ||
| # Changes here should be reflected in the mne/utils/config.py dev dependencies section | ||
| test_extra = [ | ||
| "edfio >= 0.4.10", | ||
| "eeglabio", | ||
| "imageio >= 2.6.1", | ||
| "imageio-ffmpeg >= 0.4.1", | ||
| "jupyter_client", | ||
| "mne-bids", | ||
| "nbclient", | ||
| "nbformat", | ||
| "neo", | ||
| "nitime", | ||
| "pybv", | ||
| "snirf", | ||
| "sphinx-gallery", | ||
| "statsmodels", | ||
| {include-group = "test"}, | ||
| ] | ||
|
|
||
| [project] | ||
| authors = [ | ||
| {email = "[email protected]", name = "Alexandre Gramfort"}, | ||
|
|
@@ -52,35 +120,6 @@ scripts = {mne = "mne.commands.utils:main"} | |
| [project.optional-dependencies] | ||
| # Leave this one here for backward-compat | ||
| data = [] | ||
| dev = ["mne[doc,test]", "rcssmin"] | ||
| # Dependencies for building the documentation | ||
| doc = [ | ||
| "graphviz", | ||
| "intersphinx_registry >= 0.2405.27", | ||
| "ipython != 8.7.0", # also in "full-no-qt" and "test" | ||
| "memory_profiler", | ||
| "mne-bids", | ||
| "mne-connectivity", | ||
| "mne-gui-addons", | ||
| "neo", | ||
| "numpydoc", | ||
| "openneuro-py", | ||
| "psutil", | ||
| "pydata_sphinx_theme >= 0.15.2", | ||
| "pygments >= 2.13", | ||
| "pytest", | ||
| "pyxdf", | ||
| "pyzmq != 24.0.0", | ||
| "seaborn != 0.11.2", | ||
| "selenium >= 4.27.1", | ||
| "sphinx >= 6", | ||
| "sphinx-design", | ||
| "sphinx-gallery >= 0.16", | ||
| "sphinx_copybutton", | ||
| "sphinxcontrib-bibtex >= 2.5", | ||
| "sphinxcontrib-towncrier >= 0.5.0a0", | ||
| "sphinxcontrib-youtube", | ||
| ] | ||
| full = ["mne[full-no-qt]", "PyQt6 != 6.6.0", "PyQt6-Qt6 != 6.6.0, != 6.7.0"] | ||
| # Dependencies for full MNE-Python functionality (other than raw/epochs export) | ||
| # We first define a variant without any Qt bindings. The "complete" variant, mne[full], | ||
|
|
@@ -138,44 +177,6 @@ full-pyqt6 = ["mne[full]"] | |
| full-pyside6 = ["mne[full-no-qt]", "PySide6 != 6.7.0, != 6.8.0, != 6.8.0.1, != 6.9.1"] | ||
| # Dependencies for MNE-Python functions that use HDF5 I/O | ||
| hdf5 = ["h5io >= 0.2.4", "pymatreader"] | ||
| # Dependencies for running the test infrastructure | ||
| test = [ | ||
| "codespell", | ||
| "flaky", | ||
| "ipython != 8.7.0", # for testing notebook backend; also in "full-no-qt" and "doc" | ||
| "mypy", | ||
| "numpydoc", | ||
| "pre-commit", | ||
| "pytest >= 8.0", | ||
| "pytest-cov", | ||
| "pytest-qt", | ||
| "pytest-timeout", | ||
| "ruff", | ||
| "toml-sort", | ||
| "tomli; python_version < '3.11'", | ||
| "twine", | ||
| "vulture", | ||
| "wheel", | ||
| ] | ||
| # Dependencies for being able to run additional tests (rare/CIs/advanced devs) | ||
| # Changes here should be reflected in the mne/utils/config.py dev dependencies section | ||
| test_extra = [ | ||
| "edfio >= 0.4.10", | ||
| "eeglabio", | ||
| "imageio >= 2.6.1", | ||
| "imageio-ffmpeg >= 0.4.1", | ||
| "jupyter_client", | ||
| "mne-bids", | ||
| "mne[test]", | ||
| "nbclient", | ||
| "nbformat", | ||
| "neo", | ||
| "nitime", | ||
| "pybv", | ||
| "snirf", | ||
| "sphinx-gallery", | ||
| "statsmodels", | ||
| ] | ||
|
|
||
| [project.urls] | ||
| "Bug Tracker" = "https://github.com/mne-tools/mne-python/issues/" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,14 @@ | ||
| #!/bin/bash -ef | ||
|
|
||
| python -m pip install --upgrade "pip!=20.3.0" build | ||
| python -m pip install --upgrade "pip>=25.1" build | ||
| python -m pip install --upgrade --progress-bar off \ | ||
| -ve .[full] \ | ||
| --group=test \ | ||
| --group=doc \ | ||
| -r doc/sphinxext/related_software.txt \ | ||
| --only-binary "numpy,dipy,scipy,matplotlib,pandas,statsmodels" \ | ||
| -ve .[full,test,doc] "numpy>=2" \ | ||
| "git+https://github.com/pyvista/pyvista.git" \ | ||
| "git+https://github.com/sphinx-gallery/sphinx-gallery.git" \ | ||
| "git+https://github.com/mne-tools/mne-bids.git" \ | ||
| "git+https://github.com/mne-tools/mne-qt-browser.git" \ | ||
| \ | ||
| alphaCSC autoreject bycycle conpy emd fooof meggie \ | ||
| mne-ari mne-bids-pipeline mne-faster mne-features \ | ||
| mne-icalabel mne-lsl mne-microstates mne-nirs mne-rsa \ | ||
| neurodsp neurokit2 niseq nitime pactools mnelab \ | ||
| plotly pycrostates pyprep pyriemann python-picard sesameeg \ | ||
| sleepecg tensorpac yasa meegkit eeg_positions wfdb \ | ||
| curryreader | ||
| "git+https://github.com/pyvista/pyvista.git" \ | ||
| "git+https://github.com/sphinx-gallery/sphinx-gallery.git" | ||
| python -m pip install --upgrade --progress-bar off --no-deps cross-domain-saliency-maps |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.