Skip to content

Conversation

@ultrasecreth
Copy link
Member

Implements #324

@ultrasecreth
Copy link
Member Author

@mockitoguy mind double-checking this?
I assume that merging it to master won't trigger a release to maven central unless I add [ci maven-central-release], is that correct?

This was referenced Dec 20, 2020
@mockitoguy
Copy link
Member

This looks great! In order to start releasing to Maven Central we need to change this line to read the env variable.

Copy link
Member

@mockitoguy mockitoguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See my comment on the PR regarding the maven central release.

@ultrasecreth
Copy link
Member Author

this line

Cool, will do so in a follow-up PR

@ultrasecreth ultrasecreth merged commit 11248e2 into release/1.x Dec 23, 2020
@ultrasecreth ultrasecreth deleted the gh-actions branch December 23, 2020 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants