-
Couldn't load subscription status.
- Fork 100
Addition of the functions get_optimizer_by_name and get_name for optimizer DT #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jvdp1, the code looks fine.
What is the need for this? Is it for the user to be able to instantiate an optimizer by a string? Or does it add some new functionality that wasn't already possible?
|
For getting the optimizer name, what do you think about setting a |
Yes, it is. In my case, the user provides the name of the optimizer in a TOML file. |
|
That sounds good. And I realize now that it mirrors the same functionality for activation functions ( Just let me know what you think about
and this can go ahead. |
I think it is a good idea, and probably more efficient. I will implement it. |
|
I'm sorry for the confusion and back and forth. I now see that |
Addition of the functions
get_optimizer_by_nameget_namefor optimizer DTI also set the function
get_activation_by_nameaspure