Skip to content

Conversation

@sk-pub
Copy link
Contributor

@sk-pub sk-pub commented Nov 18, 2024

Description

The runtime package uses a dynamic ESM import. It already has webpackIgnore to avoid bundler modifications (added in #3054).
This PR adds a similar /* @vite-ignore */ comment for Vite.

Related Issue

#3250

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: 7199bd3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@module-federation/runtime Patch
@module-federation/devtools Patch
@module-federation/data-prefetch Patch
@module-federation/dts-plugin Patch
@module-federation/nextjs-mf Patch
@module-federation/node Patch
@module-federation/retry-plugin Patch
@module-federation/runtime-tools Patch
@module-federation/webpack-bundler-runtime Patch
@module-federation/bridge-react Patch
@module-federation/bridge-vue3 Patch
@module-federation/enhanced Patch
@module-federation/modern-js Patch
@module-federation/rspack Patch
@module-federation/rsbuild-plugin Patch
@module-federation/storybook-addon Patch
@module-federation/modernjsapp Patch
@module-federation/sdk Patch
@module-federation/managers Patch
@module-federation/manifest Patch
@module-federation/third-party-dts-extractor Patch
@module-federation/bridge-shared Patch
@module-federation/bridge-react-webpack-plugin Patch
@module-federation/error-codes Patch
@module-federation/esbuild Patch
@module-federation/utilities Patch
website-new Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 7199bd3
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/6745003a6a54c4000814f887
😎 Deploy Preview https://deploy-preview-3251--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sk-pub sk-pub changed the title fix(runtime): add @vite-ignore for import in loadEsmEntry fix(runtime): add @vite-ignore for dynamic import in loadEsmEntry Nov 18, 2024
@sk-pub
Copy link
Contributor Author

sk-pub commented Nov 19, 2024

Hi @ScriptedAlchemy,

Could you take a look at the PR? It's similar to yours #3054.

@ScriptedAlchemy
Copy link
Member

Will do. Probably tomorrow

@ScriptedAlchemy ScriptedAlchemy merged commit e26d107 into module-federation:main Nov 25, 2024
14 checks passed
@2heal1 2heal1 mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants