chore(web): change web build to produce esm instead of cjs COMPASS-9934 #7432
Conversation
| * runtime exports not being built correctly. We should investigate and try to | ||
| * fix this to remove this custom chunk splitting logic. | ||
| */ | ||
| function createSiblingBundleFromLeafDeps( |
There was a problem hiding this comment.
Another benefit of this is that we don't need custom split chunk logic anymore
…ues in the sandbox
gribnoysup
changed the title
| externals: { | ||
| react: 'commonjs2 react', | ||
| 'react-dom': 'commonjs2 react-dom', | ||
| react: ['__compassWebSharedRuntime', 'React'], |
There was a problem hiding this comment.
How does __compassWebSharedRuntime work here? Does it mean that React would be accessible from window.__compassWebSharedRuntime?
There was a problem hiding this comment.
Yes! Actually I'm wrong in saying that is it fully backwards compatible, I updated the PR description. I'll open an mms PR is a sec to illustrate
There was a problem hiding this comment.
Opened https://github.com/10gen/mms/pull/143845 that shows how this will work
There was a problem hiding this comment.
Now it makes sense to me. Looks nice, thanks.
[nit]: can you add a comment so that someone does not change it unintentionally?
2 participants
We're planning to switch mms to load compass-web from external cdn instead of having it bundled with the whole mms application, first step into that direction is to switch compass-web distribution to be a native esm module instead of a cjs one.
This change is fully backwards compatible with how the compass-web library is being consumed by mms right nowThis is a breaking change in how compass-web get embedded in the consumer app, but it can be done in safe, backwards compatible way where the the old compass-web is still working, while we do the prep work for the new version to be included