-
Notifications
You must be signed in to change notification settings - Fork 302
Include Mongolid Library #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: ravanscafi <[email protected]>
|
@jmikola thanks for the review, I've updated it and gave more context. |
jmikola
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for losing track of this. I've made some final suggestions.
@terakilobyte, @zach-carr: feel free to merge this with the suggested changes.
| Built on top of `Mongolid`, it provides many integrations with the framework, | ||
| while leveraging some core features of it. You might find some similarities | ||
| with `Eloquent`, but this library is not a replacement for it, as it tries | ||
| to follow MongoDB concepts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested rephrase:
Built on top of the Mongolid ODM, this library provides integrations with the framework and some of its core features. There are some similarities with Eloquent but this library is designed specifically with MongoDB concepts in mind.
| - `Mongolid <https://github.com/leroy-merlin-br/mongolid>`_: Easy, powerful, | ||
| and ultrafast ODM for PHP and MongoDB. Implements ActiveRecord design | ||
| pattern accounting for MongoDB concepts. It supports embedded and referenced | ||
| documents. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested rephrase:
Easy, powerful, and ultrafast ODM for PHP and MongoDB. Implements both ActiveRecord and DataMapper design patterns and supports embedded and referenced documents.
This is based on mongodb#463 with suggested changes applied.
|
Sorry that we lost track of this. I've incorporated the suggested changes and opened #669, so hopefully that can be merged soon. |
* Add Mongolid library This is based on #463 with suggested changes applied. * Revise Mongolid description
|
Closed as per @jmikola |
Easy, powerful and ultrafast ODM for PHP7 build on top of the new mongodb driver.