DOCS-11064 - Shard and config servers must be replica set members. #3188

jdestefano-mongo · 2018-01-04T00:57:27Z

This change is

kay-kim · 2018-01-14T18:04:26Z

source/includes/steps-3.6-upgrade-sharded-cluster.yaml

-         :setting:`net.bindIp` setting). For more information, see
-         :ref:`3.6-bind_ip-compatibility`.
+      #. Start the |newversion| binary with the following required
+         options and any previously used optional command line options:


Which options in the code block are required and which are optional? As only configsvr and replSet are required.

Good point. This section was flawed both technically (missing --replSet) and grammatically. I thought generalizing would be better than listing out all the options present in the example in the text, but managed to create a different issue.

I was going to rephrase with only --configsvr and --replSet as required, but also realized --bind_ip is pretty important so I ended up just listing the options.

Please let me know if you have any suggestions.

kay-kim · 2018-01-14T18:06:36Z

source/release-notes/3.6-upgrade-sharded-cluster.txt

+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+Starting in MongoDB 3.6, :program:`mongod` instances with the shard or
+config server role must be replica set members. The following procedure


I believe starting in 3.4, config servers had to be replica sets

https://docs.mongodb.com/manual/release-notes/3.4/#removal-of-support-for-sccc-config-servers

Removed with the assumption 3.4 config servers will already be running with replication. Alternatively, I could add a separate paragraph covering the 3.4 config server behavior.

kay-kim · 2018-01-14T18:10:08Z

source/includes/steps-3.6-upgrade-sharded-cluster.yaml

-   language: javascript
-   code: |
-      db.adminCommand( { setFeatureCompatibilityVersion: "3.6" } )
+


just an fyi --
to make the code block copyable inside the yaml "action" block, you can just add a copyable: true

action:
copyable: true
language: blah
code:

Reverted. Done.

kay-kim

some small things

kay-kim · 2018-01-16T21:09:13Z

source/includes/steps-3.6-upgrade-sharded-cluster.yaml

-   Upgrade the shards one at a time. If the shards are replica sets, for each shard:
+   Upgrade the shards one at a time. If you are running standalone
+   shards, first convert them to a
+   :doc:`replica set</tutorial/convert-standalone-to-replica-set>`.


The location of this conversion seems not quite right. Since now, my config servers are already 3.6

Also, we mention standalone in

https://docs-mongodbcom-staging.corp.mongodb.com/jdestefano/DOCS-11064/reference/method/sh.addShard.html

And, did you test whether if you had a standalone shard, that just changing to the repl set correctly updates the shard meta data held by the config servers?

Sorry, I'm not sure I understand the first comment? Let's discuss tomorrow.

Updated sh.addShard and the addShard dbcommand.

I did not test the meta data scenario. I am not sure how to do this off the top of my head but can look into this tomorrow if needed.

kay-kim · 2018-01-16T21:09:47Z

source/includes/steps-3.6-upgrade-sharded-cluster.yaml

-         |newversion| binary:
+         <sharding.clusterRole>`, :setting:`replication.replSetName`,
+         :setting:`net.port`, and :setting:`net.bindIp`
+         then start the |newversion| binary:


probably need a comma before the then

kay-kim · 2018-01-16T21:11:07Z

source/includes/options-mongod.yaml

+     You must deploy shard servers as a replica set with the
+     :option:`--replSet` option specified. To deploy sharded clusters
+     with replication, follow the appropriate tutorial depending on your
+     :ref:`sharding strategy<sharding-strategy>`:


Is this more To deploy sharded clusters with shard replica sets, ...

Good suggestion, thanks.

kay-kim · 2018-01-16T21:11:54Z

source/includes/options-mongod.yaml

+
+     .. versionchanged:: 3.6
+
+     You must deploy shard servers as a replica set with the


shard servers -> shards

(since the individual servers are components of the repl set)

kay-kim · 2018-01-16T21:12:26Z

source/includes/options-mongod.yaml

+     .. versionchanged:: 3.6
+
+     You must deploy shard servers as a replica set with the
+     :option:`--replSet` option specified. To deploy sharded clusters


well, I suppose I could also use the config file in which case, I don't need to specify --replSet.

Added the config file setting.

kay-kim · 2018-01-16T21:17:23Z

source/includes/options-mongod.yaml

+
+     - :doc:`/tutorial/deploy-sharded-cluster-hashed-sharding`
+
+     - :doc:`/tutorial/deploy-sharded-cluster-ranged-sharding`


We should also delete the standalone blurb on the tutorials (see end of section)

https://docs-mongodbcom-staging.corp.mongodb.com/jdestefano/DOCS-11064/tutorial/deploy-sharded-cluster-hashed-sharding.html#add-shards-to-the-cluster

https://docs-mongodbcom-staging.corp.mongodb.com/jdestefano/DOCS-11064/tutorial/deploy-sharded-cluster-ranged-sharding.html#add-shards-to-the-cluster

Also, both
https://docs-mongodbcom-staging.corp.mongodb.com/jdestefano/DOCS-11064/core/sharded-cluster-components.html

https://docs-mongodbcom-staging.corp.mongodb.com/jdestefano/DOCS-11064/core/sharded-cluster-shards.html

Each shard can be deployed as a replica set. (no longer can be -> must be)

Done. As for the sharded-cluster-components and sharded-cluster-shards, I used the "As of MongoDB 3.X, ..." Language. Is this ok or should I use .. versionchanged:: or none of that stuff?

kay-kim · 2018-01-16T21:20:08Z

source/includes/steps-3.6-upgrade-sharded-cluster.yaml

-   Upgrade the shards one at a time. If the shards are replica sets, for each shard:
+   Upgrade the shards one at a time. If you are running standalone
+   shards, first convert them to a
+   :doc:`replica set</tutorial/convert-standalone-to-replica-set>`.


Also, we mention standalone in

https://docs-mongodbcom-staging.corp.mongodb.com/jdestefano/DOCS-11064/reference/method/sh.addShard.html

And, did you test whether if you had a standalone shard, that just changing to the repl set correctly updates the shard meta data held by the config servers?

jdestefano-mongo

Made all the changes except on one where I was confused. Opened the following on appspot incase you'd prefer to review there:

https://mongodbcr.appspot.com/176800001/

Regards,
Jon

jdestefano-mongo · 2018-01-16T21:40:53Z

source/includes/options-mongod.yaml

+
+     .. versionchanged:: 3.6
+
+     You must deploy shard servers as a replica set with the


jdestefano-mongo · 2018-01-16T21:44:30Z

source/includes/options-mongod.yaml

+     You must deploy shard servers as a replica set with the
+     :option:`--replSet` option specified. To deploy sharded clusters
+     with replication, follow the appropriate tutorial depending on your
+     :ref:`sharding strategy<sharding-strategy>`:


Good suggestion, thanks.

jdestefano-mongo · 2018-01-16T22:15:42Z

source/includes/options-mongod.yaml

+     .. versionchanged:: 3.6
+
+     You must deploy shard servers as a replica set with the
+     :option:`--replSet` option specified. To deploy sharded clusters


Added the config file setting.

jdestefano-mongo · 2018-01-16T22:17:07Z

source/includes/steps-3.6-upgrade-sharded-cluster.yaml

-         |newversion| binary:
+         <sharding.clusterRole>`, :setting:`replication.replSetName`,
+         :setting:`net.port`, and :setting:`net.bindIp`
+         then start the |newversion| binary:


jdestefano-mongo · 2018-01-16T22:57:05Z

source/includes/options-mongod.yaml

+
+     - :doc:`/tutorial/deploy-sharded-cluster-hashed-sharding`
+
+     - :doc:`/tutorial/deploy-sharded-cluster-ranged-sharding`


Done. As for the sharded-cluster-components and sharded-cluster-shards, I used the "As of MongoDB 3.X, ..." Language. Is this ok or should I use .. versionchanged:: or none of that stuff?

jdestefano-mongo · 2018-01-17T05:23:43Z

source/includes/steps-3.6-upgrade-sharded-cluster.yaml

-   Upgrade the shards one at a time. If the shards are replica sets, for each shard:
+   Upgrade the shards one at a time. If you are running standalone
+   shards, first convert them to a
+   :doc:`replica set</tutorial/convert-standalone-to-replica-set>`.


Sorry, I'm not sure I understand the first comment? Let's discuss tomorrow.

Updated sh.addShard and the addShard dbcommand.

I did not test the meta data scenario. I am not sure how to do this off the top of my head but can look into this tomorrow if needed.

kay-kim · 2018-01-17T05:38:46Z

Thank you. Will review on appspot. I was going to request it in my comments, but didn't want to be pushy :D
As for my first comment regarding the location of the conversion, ...

It seems that if I have a 3.4 sharded cluster with standalone shards, it's seems strange to upgrade the config servers to 3.6, then come across the steps to convert the 3.4 standalone shards to 3.4 replica sets. By the update shards step, you have a mixed cluster with the 3.6 config servers and the 3.4 shards, and I'm not sure if the 3.6 config servers will already complain about the shards at that point. So, I was just stating that we probably should update the 3.4 standalone shards to 3.6 config servers as a prereq. Unless the third point with the meta data-- that is you tried the upgrade in the order listed, and changed a standalone shard to a replica set and the config servers didn't complain, then ...

Can discuss tomorrow. Will take a look at changes tomorrow.

kay-kim · 2018-02-13T17:43:52Z

closing as work has been merged

kay-kim suggested changes Jan 14, 2018

View reviewed changes

jdestefano-mongo force-pushed the DOCS-11064 branch from ffa866a to b80c95b Compare January 16, 2018 21:00

kay-kim suggested changes Jan 16, 2018

View reviewed changes

DOCS-11064 - Shard and config servers must be replica set members.

10cfa3d

jdestefano-mongo force-pushed the DOCS-11064 branch from b80c95b to 10cfa3d Compare January 17, 2018 05:20

jdestefano-mongo commented Jan 17, 2018

View reviewed changes

kay-kim closed this Feb 13, 2018

jeff-allen-mongo pushed a commit that referenced this pull request May 23, 2023

DOCS-11914 BACKPORT (#3188)

6ba0f66


		.. versionchanged:: 3.6

		You must deploy shard servers as a replica set with the


		- :doc:`/tutorial/deploy-sharded-cluster-hashed-sharding`

		- :doc:`/tutorial/deploy-sharded-cluster-ranged-sharding`

DOCS-11064 - Shard and config servers must be replica set members. #3188

DOCS-11064 - Shard and config servers must be replica set members. #3188

Uh oh!

Conversation

jdestefano-mongo commented Jan 4, 2018 • edited by atsansone Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kay-kim left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdestefano-mongo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kay-kim commented Jan 17, 2018

Uh oh!

kay-kim commented Feb 13, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jdestefano-mongo commented Jan 4, 2018 •

edited by atsansone

Loading