RUBY-3378 Document CSOT #2884
Merged
RUBY-3378 Document CSOT #2884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbevi
reviewed
Jul 5, 2024
lib/mongo/client.rb
Outdated
Comment on lines
945
to
946
| # @option options [ Integer ] :timeout_ms The operation timeout in milliseconds. | ||
| # Must a non-negative integer. An explicit value of 0 means infinite. |
There was a problem hiding this comment.
Suggested change
| # @option options [ Integer ] :timeout_ms The operation timeout in milliseconds. | |
| # Must a non-negative integer. An explicit value of 0 means infinite. | |
| # @option options [ Integer ] :timeout_ms The operation timeout in milliseconds. | |
| # Must be a non-negative integer. An explicit value of 0 means infinite. |
There was a problem hiding this comment.
Can you change "Must a non-negative" to "Must be a non-negative" throughout this PR?
There was a problem hiding this comment.
Did this, good catch, thanks!
alexbevi
reviewed
Jul 5, 2024
lib/mongo/client.rb
Outdated
| # @option opts [ Integer | nil ] :timeout_ms Operation timeout in milliseconds. | ||
| # Must a positive integer. The default value is unset which means infinite. | ||
| # @option options [ Integer ] :timeout_ms The operation timeout in milliseconds. | ||
| # Must a non-negative integer. An explicit value of 0 means infinite. |
There was a problem hiding this comment.
Suggested change
| # Must a non-negative integer. An explicit value of 0 means infinite. | |
| # Must be a non-negative integer. An explicit value of 0 means infinite. |
jamis
approved these changes
Jul 8, 2024
Co-authored-by: Jamis Buck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.