CLOUDP-349078: custom roles regression tests #551
+347
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.0 Release NotesNew Features
Bug Fixes
|
lsierant
added
the
skip-changelog
lsierant
force-pushed
the
lsierant/custom-roles-regression-tests
branch
3 times, most recently
from
3040210 to
70c14e8
Compare
lsierant
force-pushed
the
lsierant/custom-roles-regression-tests
branch
from
70c14e8 to
c150032
Compare
lsierant
commented
Oct 27, 2025
|
|
||
|
|
||
| @fixture(scope="module") | ||
| def project_name_prefix(namespace: str) -> str: |
There was a problem hiding this comment.
this is not necessary - in evg namespaces are already randomized
lsierant
commented
Oct 27, 2025
| mongodb_role_with_empty_strings["spec"]["roles"][0]["role"] = "readWrite" | ||
| mongodb_role_with_empty_strings.update() | ||
|
|
||
| wait_until(lambda: replica_set.get_automation_config_tester().reached_version(rs_version + 1), timeout=120) |
There was a problem hiding this comment.
asserting for versions is not good:
- it prevents from re-running the test locally
- it increases risk of flakiness in case any other changes were performed in the meantime
it's better to just wait for the desired state of AC
lsierant
commented
Oct 27, 2025
| export RELEASE_INITIAL_COMMIT_SHA="9ed5f98fc70c5b3442f633d2393265fb8a2aba0c" | ||
| export RELEASE_INITIAL_VERSION="1.3.0" | ||
|
|
||
| export CLUSTER_TYPE=kind |
There was a problem hiding this comment.
local run was failing due to undefined errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds regression test for custom roles ensuring we will keep backwards compatibility wrt handling empty strings vs omitted fields.
In the subsequent #553 the serialization rules for custom roles will be changed.
Proof of Work
Tests passing.