Skip to content

Conversation

@leplatrem
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.01%. Comparing base (39ea4e4) to head (1e5c540).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files          22       22           
  Lines         705      707    +2     
  Branches       96       96           
=======================================
+ Hits          691      693    +2     
  Misses          8        8           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leplatrem
Copy link
Contributor Author

leplatrem commented Feb 23, 2024

Pytest lint made me do weird things, because:

PT004 Fixture `setup_request_summary_logger` does not return anything, add leading underscore

And then:

def test_request_summary(caplog, test_client, _setup_request_summary_logger):
     # ...

PT019 Fixture `_setup_request_summary_logger` without value is injected as parameter, use `@pytest.mark.usefixtures` instead

@leplatrem leplatrem merged commit 6b9e191 into main Feb 29, 2024
@leplatrem leplatrem deleted the use-ruff branch February 29, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants