Skip to content

Conversation

@b4handjr
Copy link
Contributor

The docker image is being built with a postcss-loader version that has been updated with a breaking change. This pins the version to a known working state until we can investigate further.

Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Make sure the issue about fixing this mentions putting the tilde back in the version spec.

@b4handjr
Copy link
Contributor Author

I am getting this failure on travis:

Summary of all failing tests
FAIL tests/unit/TestPackageJson.js
  � Package JSON › should have devDependencies[postcss-loader] version prefixed with "^"

    expect(received).toEqual(expected)
    
    Expected value to equal:
      StringMatching /^(\^|git)/
    Received:
      "2.1.1"
      
      at Object.<anonymous> (tests/unit/TestPackageJson.js:27:50)

@b4handjr b4handjr requested a review from kumar303 March 19, 2018 21:18
Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ if the tests pass

const skipDevDeps = [];

// postcss-loader: https://github.com/mozilla/addons-frontend/issues/4592
const skipDevDeps = ['postcss-loader'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, I forgot about that

@codecov-io
Copy link

codecov-io commented Mar 19, 2018

Codecov Report

Merging #4591 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4591   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files         203      203           
  Lines        4722     4722           
  Branches      963      963           
=======================================
  Hits         4508     4508           
  Misses        188      188           
  Partials       26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5475499...29e2619. Read the comment docs.

@b4handjr b4handjr merged commit 6b3a9e0 into mozilla:master Mar 19, 2018
@b4handjr b4handjr deleted the bump-postcss-loader-to-2.1.1 branch March 19, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants