Skip to content

Fix extract_from_see_also() with None values #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Fix extract_from_see_also() with None values #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jbi/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ def issue_type(self) -> str:

def extract_from_see_also(self):
"""Extract Jira Issue Key from see_also if jira url present"""
if not self.see_also and len(self.see_also) > 0:
if not self.see_also or len(self.see_also) == 0:
return None

for url in self.see_also: # pylint: disable=not-an-iterable
Expand Down
4 changes: 2 additions & 2 deletions jbi/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ def execute_action(
The value returned by the action call is returned.
"""
log_context = RunnerLogContext(
bug=request.bug.dict(),
request=request.dict(),
bug=request.bug,
request=request,
operation=Operation.HANDLE,
)
try:
Expand Down
1 change: 1 addition & 0 deletions tests/unit/test_bugzilla.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def test_jira_labels(whiteboard, expected):
@pytest.mark.parametrize(
"see_also,expected",
[
(None, None),
([], None),
(["foo"], None),
(["fail:/format"], None),
Expand Down