Skip to content

Do not mutate the request object (fixes #227) #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 31, 2022
Merged

Do not mutate the request object (fixes #227) #230

merged 5 commits into from
Aug 31, 2022

Conversation

@leplatrem
Copy link
Contributor

@leplatrem leplatrem commented Aug 30, 2022

fixes #227

@leplatrem leplatrem added the breaking-change Pull requests that introduce a breaking change label Aug 30, 2022
@leplatrem leplatrem marked this pull request as ready for review August 30, 2022 19:42
@leplatrem leplatrem requested a review from a team as a code owner August 30, 2022 19:42
grahamalama
grahamalama approved these changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@grahamalama grahamalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@leplatrem leplatrem merged commit d11a98a into main Aug 31, 2022
@leplatrem leplatrem deleted the 227-do-not-mutate-request branch August 31, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@grahamalama grahamalama grahamalama approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking-change Pull requests that introduce a breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not mutate the incoming request object

3 participants

@leplatrem @grahamalama