Split actions into reusable steps (fixes #213, fixes #77, embeds #233, #236, #253) #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leplatrem
force-pushed
the
213-split-default-action-into-functions
branch
from
f2dcb06 to
5fb2110
Compare
bsieber-mozilla
approved these changes
Sep 1, 2022
Contributor
bsieber-mozilla
left a comment
bsieber-mozilla
left a comment
There was a problem hiding this comment.
Thanks for the efforts in this PR and #233.
I think we can land this and iterate on this "pipeline" approach we discussed in the meeting today.
grahamalama
approved these changes
Sep 2, 2022
Contributor
grahamalama
left a comment
grahamalama
left a comment
There was a problem hiding this comment.
Looks good! I'm approving this knowing that #233 is a fast follow and we'll be quickly iterating on this design, but these were just things I wanted to comment on for posterity if for nothing else.
Contributor
Author
Contributor
That's a good idea! |
…ors) (#236) * Rename ActionLogContext to ActionContext * Rename log_context to context * Remove := operator and chain operations * Remove the maybe_ from services.jira * Align signatures of action functions * Do not duplicate parameters between init and call * Runner now instantiates context * Pass actions contexts to action tests * Update actions docs * Remove redundant parameters * Adjust parameters between default.py and jira.py * Inherit JiraContext from Context * Remove useless and confusing condition * Replace repetitive calls with list of steps * Let the runner set the ActionContext operation * Reintroduce maybe_ for optional steps * Load default action steps from configuration (#253) * Move steps to jbi.actions.steps * Rename test_default to test_steps * Move test_default_with_assignee_and_status into test_steps * Load default action steps from configuration * Add tests for the default action behaviour * Rename groups of steps. create -> new, update -> existing * Remove default value config/config.prod.yaml Co-authored-by: bsieber-mozilla <[email protected]> * Move remapping of steps into helper * Remove useless pylint annotation * Adjust docstrings * Merge unspecified groups with default ones * Update secrets baseline Co-authored-by: bsieber-mozilla <[email protected]> Co-authored-by: bsieber-mozilla <[email protected]>
Contributor
…ion-into-functions
leplatrem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #213
I removed some of the class-based stuff, but not everything, we should agree on a design for #77 before we can go further IMO