Start migrating source code to strict typing #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we start the process of migrating the project to being strictly typed with mypy. To do this, we used mypy config to enable all strict type rules that apply to the module level (some strict rules can't be applied at the module level). We also specify a list of modules to apply those rules against. The goal will be to gradually add more modules to the list until we've added all of the modules, at which point we will check the entire source directory with `strict` enabled.
leplatrem
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we start the process of migrating the project to being strictly typed with mypy.
To do this, we use mypy config to enable all strict type rules that apply to the module level (some strict rules can't be applied at the module level). We also specify a list of modules to apply those rules against. The goal will be to gradually add more modules to the list until we've added all of the modules, at which point we will check the entire source directory with
strictenabled.